Comments on: Thought for Friday: What are we going to do about the crap code ? http://objectopia.com/2009/07/24/what-are-we-going-to-do-about-the-crap-code/ Tue, 06 Dec 2011 08:48:38 +0000 hourly 1 http://wordpress.com/ By: Blog harvest, February 2010 « Schneide Blog http://objectopia.com/2009/07/24/what-are-we-going-to-do-about-the-crap-code/#comment-44 Sat, 27 Feb 2010 17:39:35 +0000 http://objectopia.com/?p=183#comment-44 [...] What are we going to do about the crap code ? – Chris Burnley analyzes the causes for crappy code and suggests some solutions. Our solution is to avoid crappy code at all costs. Crap4j is a great tool to help you with that on the coding level. [...]

]]> By: nerdgerl http://objectopia.com/2009/07/24/what-are-we-going-to-do-about-the-crap-code/#comment-18 Fri, 24 Jul 2009 04:53:54 +0000 http://objectopia.com/?p=183#comment-18 Luckily for me I was writing unit and integration tests around a piece of work that was already written. I got my tests to pass, refactored the code then made sure the tests still passed with my changes.

Another issue im having is ‘Crappy Process’ Just because we are doing something someway doesn’t mean it’s the best. CI, releases etc.

]]> By: Chris Burnley http://objectopia.com/2009/07/24/what-are-we-going-to-do-about-the-crap-code/#comment-17 Fri, 24 Jul 2009 04:49:57 +0000 http://objectopia.com/?p=183#comment-17 I’d opt for b), but I would try not to cleanup a bit of code that was unrelated to the fix I was making. I.e. you don’t want to potentially leave it it in a worse state than you started by causing a bug … then you’d really not make any friends doing that!

Chances are, the person who wrote it in the first place will be too ashamed to challenge you anyway!

]]> By: nerdgerl http://objectopia.com/2009/07/24/what-are-we-going-to-do-about-the-crap-code/#comment-16 Fri, 24 Jul 2009 04:44:58 +0000 http://objectopia.com/?p=183#comment-16 I just recently joined a new project team as a java developer, not a junior one, not a sernior one, just someone somewhere in the middle. I was shocked to find the coding mistakes made by ‘senior’ developers and faced a bit of a dilema… Should I
a) Ignore the ‘crappy code’ for now and come back to it later
b) Fix the code, check it in and possibly piss off some people by doing so.

I opted for b. I have pride in my work and to be honest, crappy code make me want to vomit. I knew my changes were increasing performance and readability so if he ended up challenging me, I felt confident backing myself up.

I think all developers should be open to coding suggestions no matter how many years they’ve been programming.

]]>